Fix the unit test failure of kafka configuring user agent #32636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
yiliuTo
requested review from
backwind1233,
chenrujun,
hui1110,
Netyyyy,
saragluna,
stliu,
moarychan and
fangjian0423
as code owners
saragluna
approved these changes
Dec 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr is to fix the unit test failure of kafka configuring user agent.
During the refactoring process of Kafka password-less connection support in #31182, we moved some methods from a util class to a superclass, and also modified them from class methods to instance methods since they are only used within that class.
However, the synchronized method
configureKafkaUserAgentshould be a class method to make it idempotent and thread-safe across calling from all subclass instances, which should not be modified as non-static.